Merge pull request #15 from anag0/dev

fixes #14
ernestmarcinko · Oct 3, 2023 · 1aa5867 · 1aa5867
2 parents 9dc17b3 + 489da1f
commit 1aa5867
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/dist/domini-core.js b/dist/domini-core.js
diff --git a/dist/domini.js b/dist/domini.js
diff --git a/examples/examples.html b/examples/examples.html
@@ -185,7 +185,7 @@ <h2 class="text-body-emphasis">Dynamic Events on New items</h2>
                     Lorem ipsum
                 </li>
             </ul>
-<pre>$('#list2_add').on('click', function(){
+<pre>$('#list2_add').on('mouseover', function(){
     $('#list2').append("<li>New list item</li>");
 });
 $('#list2').on('mouseover', 'li', function(){

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "domini",
-    "version": "0.2.3",
+    "version": "0.2.4",
     "description": "Minimalistic DOM manipulation tool",
     "main": "dist/domini.js",
     "scripts": {

diff --git a/src/core/selector.js b/src/core/selector.js
@@ -103,14 +103,14 @@ DoMini.fn.closest = function (s) {
     let elements = [];
     for ( let el of this ) {
         if ( typeof s === "string" && s !== '' ) {
-            while ((el = el.parentElement) && !el.matches(s)) ;
+            while (!el.matches(s) && (el = el.parentElement)) ;
             if ( !elements.includes(el) ) {
                 elements.push(el);
             }
         } else {
             s = s instanceof DoMini ? s.get(0) : s;
             if ( s instanceof Element ) {
-                while ((el = el.parentElement) && el !== s) ;
+                while (el !== s && (el = el.parentElement)) ;
             } else {
                 el = null;
             }