Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$(window) and $(document) not working #12

Closed
ernestmarcinko opened this issue Oct 3, 2023 · 0 comments
Closed

$(window) and $(document) not working #12

ernestmarcinko opened this issue Oct 3, 2023 · 0 comments
Assignees
@ernestmarcinko
Labels
bug Something isn't working

Comments

@ernestmarcinko
Copy link
Owner

Because of the incorrect type check for the Element interface, the $(document) and $(window) queries will return an empty Domini object.

The base.js should check for:

instanceof Element || node instanceof Document || node instanceof Window

to resolve this.
@ernestmarcinko ernestmarcinko added the bug Something isn't working label Oct 3, 2023
@ernestmarcinko ernestmarcinko self-assigned this Oct 3, 2023
ernestmarcinko added a commit that referenced this issue Oct 3, 2023
@ernestmarcinko
Merge pull request #13 from anag0/dev
9dc17b3 
fixes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ernestmarcinko ernestmarcinko

Labels
bug Something isn't working
Projects
DoMini
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ernestmarcinko