Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export concrete types #22

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Export concrete types #22

merged 2 commits into from
Apr 12, 2023

Conversation

erni27
Copy link
Owner

@erni27 erni27 commented Apr 12, 2023

This PR exports concrete types for non-sharded cache (Cache) and sharded cache (Sharded).

Changes include:

  • Rename Cache interface to Imcache
  • Export a non-sharded cache type Cache
  • Make Cache zero value ready to use
  • Export a sharded cache type Sharded
  • Update factory functions to return concrete types instead of interface

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #22 (324ce92) into master (c109d14) will increase coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   97.45%   97.49%   +0.03%     
==========================================
  Files           8        8              
  Lines         393      399       +6     
==========================================
+ Hits          383      389       +6     
  Misses         10       10              
Impacted Files Coverage Δ
cache.go 100.00% <100.00%> (ø)
option.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cache.go Outdated Show resolved Hide resolved
cache.go Show resolved Hide resolved
@erni27 erni27 changed the title Export concrete Imcache types Export concrete types Apr 12, 2023
@erni27 erni27 merged commit 3ae5464 into master Apr 12, 2023
2 checks passed
@erni27 erni27 deleted the export-concrete-types branch April 12, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants