Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SizeExceeded EvictionReason to MaxEntriesExceeded #28

Merged
merged 9 commits into from
Apr 16, 2023

Conversation

erni27
Copy link
Owner

@erni27 erni27 commented Apr 16, 2023

This PR renames EvictionReasonSizeExceeded to EvictionReasonMaxEntriesExceeded.

It makes the API more consistent.

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Merging #28 (98f6a84) into master (2f1b283) will not change coverage.
The diff coverage is 50.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files           9        9           
  Lines         514      514           
=======================================
  Hits          488      488           
  Misses         22       22           
  Partials        4        4           
Impacted Files Coverage Δ
eviction.go 0.00% <0.00%> (ø)
expiration.go 100.00% <ø> (ø)
option.go 100.00% <ø> (ø)
cache.go 96.30% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

eviction.go Outdated Show resolved Hide resolved
@erni27
Copy link
Owner Author

erni27 commented Apr 16, 2023

Code coverage patch target not satisfied because there is no test for EvictionReason Stringer implementation. I don't think they bring any value.

@erni27 erni27 merged commit 5629563 into master Apr 16, 2023
2 checks passed
@erni27 erni27 deleted the rename-size-exceeded branch April 16, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants