Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit tests #43

Merged
merged 5 commits into from
May 6, 2023
Merged

Improve unit tests #43

merged 5 commits into from
May 6, 2023

Conversation

erni27
Copy link
Owner

@erni27 erni27 commented May 6, 2023

This PR improves (and simplifies) unit tests.

Fixes #39.

@erni27 erni27 changed the title Simplify unit tests Improve unit tests May 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Merging #43 (a8acd9c) into master (5b7d897) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   95.81%   95.53%   -0.28%     
==========================================
  Files           8        8              
  Lines         717      717              
==========================================
- Hits          687      685       -2     
- Misses         26       28       +2     
  Partials        4        4              
Impacted Files Coverage Δ
replacef.go 50.00% <ø> (ø)
imcache.go 98.90% <100.00%> (ø)

imcache_test.go Outdated Show resolved Hide resolved
imcache_test.go Outdated Show resolved Hide resolved
imcache_test.go Outdated Show resolved Hide resolved
imcache_test.go Outdated Show resolved Hide resolved
imcache_test.go Outdated Show resolved Hide resolved
imcache_test.go Outdated Show resolved Hide resolved
@erni27 erni27 merged commit b892187 into master May 6, 2023
4 checks passed
@erni27 erni27 deleted the simplify-unit-tests branch May 6, 2023 21:48
@erni27 erni27 added this to the 1.1.0 Release milestone Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce boilerplate code in unit tests
2 participants