Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rand usage, typos and fields alignment #49

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Conversation

GreyXor
Copy link
Contributor

@GreyXor GreyXor commented Jun 28, 2023

  • Some typos
  • Fieldalignements, some bytes saved
  • Rename s receiver to c to match others one
  • Use NewSource instead of deprecated Seed (more info)
  • Simplify (token)(v)
fieldalignements details
/home/greyxor/Documents/Projects/imcache/cleaner.go:21:14: struct with 32 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/entry.go:6:33: struct with 40 pointer bytes could be 24
/home/greyxor/Documents/Projects/imcache/imcache.go:71:33: struct of size 80 could be 72
/home/greyxor/Documents/Projects/imcache/imcache.go:675:35: struct with 56 pointer bytes could be 32
/home/greyxor/Documents/Projects/imcache/entry_test.go:9:13: struct with 80 pointer bytes could be 72
/home/greyxor/Documents/Projects/imcache/entry_test.go:42:13: struct with 56 pointer bytes could be 48
/home/greyxor/Documents/Projects/imcache/entry_test.go:71:13: struct with 56 pointer bytes could be 48
/home/greyxor/Documents/Projects/imcache/entry_test.go:104:13: struct with 56 pointer bytes could be 48
/home/greyxor/Documents/Projects/imcache/entry_test.go:134:13: struct with 136 pointer bytes could be 112
/home/greyxor/Documents/Projects/imcache/imcache_test.go:36:16: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:294:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:307:13: struct with 48 pointer bytes could be 40
/home/greyxor/Documents/Projects/imcache/imcache_test.go:359:13: struct with 72 pointer bytes could be 64
/home/greyxor/Documents/Projects/imcache/imcache_test.go:586:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:623:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:670:27: struct with 32 pointer bytes could be 24
/home/greyxor/Documents/Projects/imcache/imcache_test.go:676:27: struct with 16 pointer bytes could be 8
/home/greyxor/Documents/Projects/imcache/imcache_test.go:742:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:778:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:809:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:870:36: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:1369:13: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/imcache_test.go:1530:14: struct with 24 pointer bytes could be 16
/home/greyxor/Documents/Projects/imcache/entry_test.go:9:13: struct with 72 pointer bytes could be 64
/home/greyxor/Documents/Projects/imcache/entry_test.go:42:13: struct with 48 pointer bytes could be 40
/home/greyxor/Documents/Projects/imcache/entry_test.go:71:13: struct with 48 pointer bytes could be 40
/home/greyxor/Documents/Projects/imcache/entry_test.go:104:13: struct with 48 pointer bytes could be 40
/home/greyxor/Documents/Projects/imcache/entry_test.go:134:13: struct with 112 pointer bytes could be 104

@erni27 erni27 added this to the 1.1.0 Release milestone Jun 28, 2023
@erni27 erni27 changed the title rand, typos and fields alignment Fix rand usage, typos and fields alignment Jun 28, 2023
Copy link
Owner

@erni27 erni27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GreyXor: Thanks for the PR! 🚀

@erni27 erni27 merged commit c2f6d27 into erni27:master Jun 28, 2023
4 checks passed
@GreyXor
Copy link
Contributor Author

GreyXor commented Jun 28, 2023

@GreyXor: Thanks for the PR! rocket

Thanks for both imcache and your reactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants