Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve evictionQueue interface #52

Merged
merged 4 commits into from
Dec 25, 2023
Merged

Conversation

erni27
Copy link
Owner

@erni27 erni27 commented Dec 24, 2023

This PR improves the eviction abstraction to enable support for different eviction policies.

Partially fixes: #51

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4312a64) 95.43% compared to head (399087a) 95.20%.

Files Patch % Lines
eviction.go 86.66% 5 Missing and 1 partial ⚠️
imcache.go 98.36% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   95.43%   95.20%   -0.24%     
==========================================
  Files           7        6       -1     
  Lines         833      834       +1     
==========================================
- Hits          795      794       -1     
- Misses         33       34       +1     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

imcache.go Outdated Show resolved Hide resolved
imcache.go Outdated Show resolved Hide resolved
imcache.go Outdated Show resolved Hide resolved
imcache.go Outdated Show resolved Hide resolved
imcache.go Outdated Show resolved Hide resolved
imcache.go Show resolved Hide resolved
@erni27 erni27 marked this pull request as ready for review December 25, 2023 14:09
@erni27 erni27 merged commit 88192fa into master Dec 25, 2023
4 checks passed
@erni27 erni27 deleted the improve-eviction-queue-interface branch December 25, 2023 14:10
@erni27 erni27 added this to the 1.2.0 Release milestone Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore other eviction policies
2 participants