Effects (fade): Delegate hiding and showing to core. Fixes #8267 - di…

…alog fadein broken since 1.9m4.
eromba · Jun 15, 2012 · d569b52 · d569b52
1 parent e2bbe04
commit d569b52
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/ui/jquery.effects.fade.js b/ui/jquery.effects.fade.js
@@ -14,23 +14,16 @@
 
 $.effects.effect.fade = function( o, done ) {
 	var el = $( this ),
-		mode = $.effects.setMode( el, o.mode || "toggle" ),
-		hide = mode === "hide";
+		mode = $.effects.setMode( el, o.mode || "toggle" );
 
-	el.show();
 	el.animate({
-		opacity: hide ? 0 : 1
+		opacity: mode
 	}, {
 		queue: false,
 		duration: o.duration,
 		easing: o.easing,
-		complete: function() {
-			if ( hide ) {
-				el.hide();
-			}
-			done();
-		}
+		complete: done
 	});
 };
 
-})(jQuery);
+})( jQuery );