Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and enable reminder notifications #9

Open
erosson opened this issue May 28, 2020 · 4 comments
Open

fix and enable reminder notifications #9

erosson opened this issue May 28, 2020 · 4 comments
Labels
blocked Waiting on something before work can continue bug Something isn't working

Comments

@erosson
Copy link
Owner

erosson commented May 28, 2020

See #6 - we removed the reminders setting for our first release, as it was broken. Re-enable it and fix it.

@erosson erosson added the bug Something isn't working label May 28, 2020
@erosson
Copy link
Owner Author

erosson commented May 28, 2020

https://docs.expo.io/versions/latest/sdk/notifications/#localnotification

OneSignal was used for push notifications. I'm not sure I have a use for push here - if we drop push notifications and settle for recurring local notifications, things get much simpler.

@erosson
Copy link
Owner Author

erosson commented May 28, 2020

implemented local push notifications. I've forgotten what text quirk used here, and it's not in the source code - so I'm leaving this disabled for a few days before releasing, so I can see some of quirk's notifications and compare my wording.

usually I prefer feature-flagging to branching, but I'm not sure how best to do feature-flagging on mobile - #14 - so for now, this is in a branch

@erosson erosson added blocked Waiting on something before work can continue and removed blocked Waiting on something before work can continue labels May 28, 2020
erosson added a commit that referenced this issue Jun 1, 2020
@erosson
Copy link
Owner Author

erosson commented Jun 1, 2020

if we drop push notifications and settle for recurring local notifications,

Unfortunately, there was a good reason for push notifications:

Important Android limitation: Local notifications are cleared when an Android device is restarted.

Showstopper for this feature on Android. (Could release it ios-only, though...)

Fortunately, there's a feature request with a recent PR on that page; expo-notifications seems to fix this: https://www.npmjs.com/package/expo-notifications

Not yet usable with ejecting, but it sounds like that will change soon. Expo 38 is supposed to be end of June, I'm in no hurry, and am waiting to see more of quirk's reminder text anyway - so let's wait this one out.

@erosson erosson added the blocked Waiting on something before work can continue label Jun 1, 2020
@erosson
Copy link
Owner Author

erosson commented Jun 8, 2020

Showstopper for this feature on Android. (Could release it ios-only, though...)

Sure, why not - released on ios in 1385632

@erosson erosson mentioned this issue Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on something before work can continue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant