Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farsi #686

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Farsi #686

merged 3 commits into from
Aug 22, 2023

Conversation

ali73
Copy link

@ali73 ali73 commented Aug 17, 2023

No description provided.

erosson
erosson requested changes Aug 22, 2023
View reviewed changes
Copy link
Owner

@erosson erosson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is great! Thanks so much for your work on this (and for waiting for me)!

Haven't tested a right-to-left language before this, but I tried it and it seems to work all right. One small typo is breaking the build, but otherwise this is good!

expo47/src/i18n.ts Outdated Show resolved Hide resolved
@erosson erosson mentioned this pull request Aug 22, 2023
Open
@erosson erosson merged commit 25b5f82 into erosson:master Aug 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erosson erosson erosson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ali73 @erosson