Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vale Action is slow because it builds Docker image every run #105

Closed
timotk opened this issue Sep 11, 2023 · 2 comments
Closed

Vale Action is slow because it builds Docker image every run #105

timotk opened this issue Sep 11, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@timotk
Copy link

timotk commented Sep 11, 2023

The problem

The Vale Action is slow, because it builds a Docker container every run.

Example

Here's my Github Action run (54 seconds in total):
image

  • 42 seconds is spent on building the Docker image
  • only 5 seconds is spent on downloading packages and running Vale

This is annoying when you update your pull requests often.

Ideas

Speed up Vale Action by:

  • Use an existing Docker image (for example through this suggestion)
  • Cache the built Docker container yourself using a cache step (not sure how)

Any other ideas?

@timotk timotk changed the title Vale Action is slow because it has to build reviewdog Docker image every run Vale Action is slow because it builds reviewdog Docker image every run Sep 11, 2023
@timotk timotk changed the title Vale Action is slow because it builds reviewdog Docker image every run Vale Action is slow because it builds Docker image every run Sep 11, 2023
@jdkato
Copy link
Member

jdkato commented Sep 15, 2023

Yes, this is not good. I'm planning on moving away from ReviewDog entirely, but I haven't had time to work on this.

@jdkato jdkato added the bug Something isn't working label Sep 15, 2023
@jdkato
Copy link
Member

jdkato commented Sep 25, 2023

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants