Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug in example template #269

Closed
Ravlen opened this issue Nov 16, 2020 · 4 comments
Closed

Minor bug in example template #269

Ravlen opened this issue Nov 16, 2020 · 4 comments

Comments

@Ravlen
Copy link

Ravlen commented Nov 16, 2020

In the example at https://docs.errata.ai/vale/cli#template-examples, the final line seems to be outputting the number of files that had an alert at error/warning/suggestion level. When I run the example template with 1300'ish files, (and one set to fail during testing), I get:

1 errors, 0 warnings and 0 suggestions in 1 file.

If no files fail, it says 0 files. Seems that the $f variable is only incrementing when an alert is thrown... or maybe .Files is only returning files with alerts? It's a very minor thing, and we've still switched to using a template, but might as well point it out. cc @jdkato

@jdkato
Copy link
Member

jdkato commented Nov 16, 2020

.Files is only returning files with alerts?

This indeed seems to be the case.

@jdkato
Copy link
Member

jdkato commented Nov 16, 2020

This will be fixed in the next release, but it'll probably be a few days. I want to make sure I get it right + fix #267 before releasing.

@Ravlen
Copy link
Author

Ravlen commented Nov 16, 2020

@jdkato No worries, take your time to make sure you got it right, we are in no rush!

@Ravlen
Copy link
Author

Ravlen commented Nov 16, 2020

@jdkato Actually, I mentioned the problem to a co-worker, who mentioned it to another co-worker, who opened a PR to try to fix it for the technical writing team 😅 #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants