Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings starting with numbers do not qualify as sentence case. #695

Closed
1 task done
loks0n opened this issue Oct 6, 2023 · 1 comment
Closed
1 task done

Headings starting with numbers do not qualify as sentence case. #695

loks0n opened this issue Oct 6, 2023 · 1 comment

Comments

@loks0n
Copy link

loks0n commented Oct 6, 2023

Check for existing issues

  • Completed

Environment

OS: MacOS
Install method: Node wrapper package
Vale version: 2.29.1

Describe the bug / provide steps to reproduce it

Headings starting with numbers, e.g. # 1. My numbered heading do not qualify as sentence case.

Reproduction steps

  1. Create a rule in your style for sentence case headings:
extends: capitalization
message: "'%s' should be in sentence case"
level: warning
scope: heading
match: $sentence
  1. Create a number heading in a file
# 1. An important heading
Some text.

## An unimportant heading
Some text
  1. Run vale with the rule from the style configured and observe the error.
1:5    warning  '1. An important heading'       mycustomstyle.SentenceCase 
                  should be in sentence case
@jdkato
Copy link
Member

jdkato commented Oct 9, 2023

This will be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants