launch a repairDatabase task on clear_resolved #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.39%) when pulling 38ca535b4ea61f63161c6f727d180935d1ff37c9 on shingara:patch-1 into a761933 on errbit:master. |
|
Coverage decreased (-0.39%) when pulling 12d9152f8176802051560ad54b783ad46dd382cf on shingara:patch-1 into a761933 on errbit:master. |
|
Coverage decreased (-0.39%) when pulling 12d9152f8176802051560ad54b783ad46dd382cf on shingara:patch-1 into a761933 on errbit:master. |
The task db:clear_resolved can delete a lot of data. I think it can be good to repairDatabase after to avoid a big database. see errbit#458
Extract the task in a class doing the job Add test on this class Update rspec and rspec-rails gems
|
I think can be merged now. Any objection ? |
|
Merging, looks good to me! |
ndbroadbent
added a commit
that referenced
this pull request
May 4, 2013
launch a repairDatabase task on clear_resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task db:clear_resolved can delete a lot of data. I think it can be good to repairDatabase after to avoid a big database.
see #458