Migration from factory girls to Fabrication Gem

Gemfile

@@ -31,8 +31,7 @@ gem 'ri_cal'
 group :development, :test do
   gem 'rspec-rails', '~> 2.6'
   gem 'webmock', :require => false
-  gem 'factory_girl', '~> 1.3.3'
-  gem 'factory_girl_rails', '~> 1.0.1'
+  gem 'fabrication'
   unless ENV['TRAVIS']
     gem 'ruby-debug', :platform => :mri_18
     gem 'ruby-debug19', :platform => :mri_19, :require => 'ruby-debug'

Gemfile.lock

@@ -55,10 +55,7 @@ GEM
       rspec (~> 2.0)
     erubis (2.6.6)
       abstract (>= 1.0.0)
-    factory_girl (1.3.3)
-    factory_girl_rails (1.0.1)
-      factory_girl (~> 1.3)
-      railties (>= 3.0.0)
+    fabrication (1.2.0)
     faraday (0.7.4)
       addressable (~> 2.2.6)
       multipart-post (~> 1.1.0)
@@ -219,8 +216,7 @@ DEPENDENCIES
   database_cleaner (~> 0.6.0)
   devise (~> 1.4.0)
   email_spec
-  factory_girl (~> 1.3.3)
-  factory_girl_rails (~> 1.0.1)
+  fabrication
   haml
   hoptoad_notifier (~> 2.4)
   htmlentities (~> 4.3.0)

app/models/problem.rb

@@ -116,7 +116,9 @@ def cache_app_attributes
       self.last_deploy_at = if (last_deploy = app.deploys.where(:environment => self.environment).last)
         last_deploy.created_at
       end
-      self.save if persisted?
+      collection.update({'_id' => self.id},
+                        {'$set' => {'app_name' => self.app_name,
+                          'last_deploy_at' => self.last_deploy_at}})
     end
   end
 

config/application.rb

@@ -45,6 +45,7 @@ class Application < Rails::Application
       g.orm             :mongoid
       g.template_engine :haml
       g.test_framework  :rspec, :fixture => false
+      g.fixture_replacement :fabrication
     end
 
     # IssueTracker subclasses use inheritance, so preloading models provides querying consistency in dev mode.

spec/controllers/apps_controller_spec.rb

@@ -10,8 +10,8 @@
   describe "GET /apps" do
     context 'when logged in as an admin' do
       it 'finds all apps' do
-        sign_in Factory(:admin)
-        3.times { Factory(:app) }
+        sign_in Fabricate(:admin)
+        3.times { Fabricate(:app) }
         apps = App.all
         get :index
         assigns(:apps).should == apps
@@ -20,12 +20,12 @@
 
     context 'when logged in as a regular user' do
       it 'finds apps the user is watching' do
-        sign_in(user = Factory(:user))
-        unwatched_app = Factory(:app)
-        watched_app1 = Factory(:app)
-        watched_app2 = Factory(:app)
-        Factory(:user_watcher, :user => user, :app => watched_app1)
-        Factory(:user_watcher, :user => user, :app => watched_app2)
+        sign_in(user = Fabricate(:user))
+        unwatched_app = Fabricate(:app)
+        watched_app1 = Fabricate(:app)
+        watched_app2 = Fabricate(:app)
+        Fabricate(:user_watcher, :user => user, :app => watched_app1)
+        Fabricate(:user_watcher, :user => user, :app => watched_app2)
         get :index
         assigns(:apps).should include(watched_app1, watched_app2)
         assigns(:apps).should_not include(unwatched_app)
@@ -36,10 +36,10 @@
   describe "GET /apps/:id" do
     context 'logged in as an admin' do
       before(:each) do
-        @user = Factory(:admin)
+        @user = Fabricate(:admin)
         sign_in @user
-        @app = Factory(:app)
-        @problem = Factory(:notice, :err => Factory(:err, :problem => Factory(:problem, :app => @app))).problem
+        @app = Fabricate(:app)
+        @problem = Fabricate(:notice, :err => Fabricate(:err, :problem => Fabricate(:problem, :app => @app))).problem
       end
 
       it 'finds the app' do
@@ -48,7 +48,7 @@
       end
 
       it "should not raise errors for app with err without notices" do
-        Factory(:err, :problem => Factory(:problem, :app => @app))
+        Fabricate(:err, :problem => Fabricate(:problem, :app => @app))
         lambda { get :show, :id => @app.id }.should_not raise_error
       end
 
@@ -60,7 +60,7 @@
 
       context "pagination" do
         before(:each) do
-          35.times { Factory(:err, :problem => Factory(:problem, :app => @app)) }
+          35.times { Fabricate(:err, :problem => Fabricate(:problem, :app => @app)) }
         end
 
         it "should have default per_page value for user" do
@@ -77,8 +77,8 @@
 
       context 'with resolved errors' do
         before(:each) do
-          resolved_problem = Factory(:problem, :app => @app)
-          Factory(:notice, :err => Factory(:err, :problem => resolved_problem))
+          resolved_problem = Fabricate(:problem, :app => @app)
+          Fabricate(:notice, :err => Fabricate(:err, :problem => resolved_problem))
           resolved_problem.resolve!
         end
 
@@ -101,7 +101,7 @@
         before(:each) do
           environments = ['production', 'test', 'development', 'staging']
           20.times do |i|
-            Factory.create(:problem, :app => @app, :environment => environments[i % environments.length])
+            Fabricate(:problem, :app => @app, :environment => environments[i % environments.length])
           end
         end
 
@@ -144,17 +144,17 @@
 
     context 'logged in as a user' do
       it 'finds the app if the user is watching it' do
-        user = Factory(:user)
-        app = Factory(:app)
-        watcher = Factory(:user_watcher, :app => app, :user => user)
+        user = Fabricate(:user)
+        app = Fabricate(:app)
+        watcher = Fabricate(:user_watcher, :app => app, :user => user)
         sign_in user
         get :show, :id => app.id
         assigns(:app).should == app
       end
 
       it 'does not find the app if the user is not watching it' do
-        sign_in Factory(:user)
-        app = Factory(:app)
+        sign_in Fabricate(:user)
+        app = Fabricate(:app)
         lambda {
           get :show, :id => app.id
         }.should raise_error(Mongoid::Errors::DocumentNotFound)
@@ -164,7 +164,7 @@
 
   context 'logged in as an admin' do
     before do
-      sign_in Factory(:admin)
+      sign_in Fabricate(:admin)
     end
 
     describe "GET /apps/new" do
@@ -176,7 +176,7 @@
       end
 
       it "should copy attributes from an existing app" do
-        @app = Factory(:app, :name => "do not copy",
+        @app = Fabricate(:app, :name => "do not copy",
                              :github_url => "github.com/test/example")
         get :new, :copy_attributes_from => @app.id
         assigns(:app).should be_a(App)
@@ -188,15 +188,15 @@
 
     describe "GET /apps/:id/edit" do
       it 'finds the correct app' do
-        app = Factory(:app)
+        app = Fabricate(:app)
         get :edit, :id => app.id
         assigns(:app).should == app
       end
     end
 
     describe "POST /apps" do
       before do
-        @app = Factory(:app)
+        @app = Fabricate(:app)
         App.stub(:new).and_return(@app)
       end
 
@@ -219,7 +219,7 @@
 
     describe "PUT /apps/:id" do
       before do
-        @app = Factory(:app)
+        @app = Fabricate(:app)
       end
 
       context "when the update is successful" do
@@ -257,7 +257,7 @@
         end
         context "failed parsing of CSV" do
           it "should set the default value" do
-            @app = Factory(:app, :email_at_notices => [1, 2, 3, 4])
+            @app = Fabricate(:app, :email_at_notices => [1, 2, 3, 4])
             put :update, :id => @app.id, :app => { :email_at_notices => 'asdf, -1,0,foobar,gd00,0,abc' }
             @app.reload
             @app.email_at_notices.should == Errbit::Config.email_at_notices
@@ -320,7 +320,7 @@
 
     describe "DELETE /apps/:id" do
       before do
-        @app = Factory(:app)
+        @app = Fabricate(:app)
         App.stub(:find).with(@app.id).and_return(@app)
       end
 

spec/controllers/deploys_controller_spec.rb

@@ -12,7 +12,7 @@
         'scm_revision'   => '19d77837eef37902cf5df7e4445c85f392a8d0d5',
         'message'        => 'johns first deploy'
       }
-      @app = Factory(:app_with_watcher, :notify_on_deploys => true, :api_key => 'APIKEY')
+      @app = Fabricate(:app_with_watcher, :notify_on_deploys => true, :api_key => 'APIKEY')
     end
 
     it 'finds the app via the api key' do
@@ -30,7 +30,7 @@
           :revision     => '19d77837eef37902cf5df7e4445c85f392a8d0d5',
           :message      => 'johns first deploy'
 
-        }).and_return(Factory(:deploy))
+        }).and_return(Fabricate(:deploy))
       post :create, :deploy => @params, :api_key => 'APIKEY'
     end
 
@@ -45,8 +45,8 @@
 
   context "GET #index" do
     before(:each) do
-      @deploy = Factory :deploy
-      sign_in Factory(:admin)
+      @deploy = Fabricate :deploy
+      sign_in Fabricate(:admin)
       get :index, :app_id => @deploy.app.id
     end