Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gem rspec-its dependency #1344

Merged
merged 1 commit into from Aug 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
Expand Up @@ -76,7 +76,6 @@ group :test do
gem 'rspec'
gem 'rspec-rails', require: false
gem 'rspec-activemodel-mocks'
gem 'rspec-its'
gem 'mongoid-rspec', require: false
gem 'fabrication'
gem 'capybara'
Expand Down
4 changes: 0 additions & 4 deletions Gemfile.lock
Expand Up @@ -323,9 +323,6 @@ GEM
rspec-expectations (3.7.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.7.0)
rspec-its (1.2.0)
rspec-core (>= 3.0.0)
rspec-expectations (>= 3.0.0)
rspec-mocks (3.7.0)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.7.0)
Expand Down Expand Up @@ -471,7 +468,6 @@ DEPENDENCIES
ri_cal
rspec
rspec-activemodel-mocks
rspec-its
rspec-rails
rubocop
rushover
Expand Down
10 changes: 8 additions & 2 deletions spec/models/error_report_spec.rb
Expand Up @@ -85,8 +85,14 @@ def framework
describe "notice create" do
before { error_report.generate_notice! }
subject { error_report.notice }
its(:message) { 'HoptoadTestingException: Testing hoptoad via "rake hoptoad:test". If you can see this, it works.' }
its(:framework) { should == 'Rails: 3.2.11' }

it 'has correct message' do
expect(subject.message).to include('HoptoadTestingException: Testing hoptoad via "rake hoptoad:test". If you can see this, it works')
end

it 'has correct framework' do
expect(subject.framework).to eq('Rails: 3.2.11')
end

it 'has complete backtrace' do
expect(subject.backtrace_lines.size).to eq 73
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
Expand Up @@ -21,7 +21,6 @@

require File.expand_path("../../config/environment", __FILE__)
require 'rspec/rails'
require 'rspec/its'
require 'email_spec'
require 'xmpp4r'
require 'xmpp4r/muc'
Expand Down