Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable remote config #1493

Merged
merged 1 commit into from Mar 22, 2021
Merged

disable remote config #1493

merged 1 commit into from Mar 22, 2021

Conversation

espen
Copy link
Contributor

@espen espen commented Mar 11, 2021

A new phone home feature in Airbrake introduced here: airbrake/airbrake-js@78387b6

This request will fail, I assume because with Errbit you self-host and do not have any project info at Airbrake backend.

@2called-chaos
Copy link
Member

As far as I understood one should also disable this in the ruby airbrake configuration, yes?

Maybe we should note somewhere that one should disable airbrake functionality that errbit cannot utilize, for example we currently have the following things disabled (I'm not 100% sure if they are all enabled by default)

# disable features errbit cannot handle (and spams log)
config.job_stats           = false
config.query_stats         = false
config.performance_stats   = false
config.remote_config       = false

I'm not sure if there are even more now, haven't really kept up with airbrake changes

@espen
Copy link
Contributor Author

espen commented Mar 13, 2021

I am not 100% sure but I think these are two different things. One is for the gem the other is for the JS reporter.

@stevecrozz stevecrozz merged commit a4e12ce into errbit:master Mar 22, 2021
@stevecrozz stevecrozz added this to the 0.10.0 milestone Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants