Fix/improve issue tracker app edit #599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve fingerprints when error messages differ only in object memory addresses
Gitlab Issues integration update
* avoid a filter to parse IssueTracker params * Add acceptance test with phantomjs to be sure the Apps editing works fine with IssueTracker * Add IssueTrackers::None the IssueTracker configure doing nothing
|
This looks great to me! Sorry for inactivity, I've been taking a little break from Errbit recently |
|
No problem @ndbroadbent I think move this PR in #612 instead. I let it open in case. but #612 start from this PR. |
|
I close it in favor of #612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request try to improve the readability of the IssueTracker edit part in App edit form.
If some people can review it ?
It's the start to extract all issue tracker from Errbit to some plugin. Can help to do it on the view side now.