Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby version from Gemfile #602

Merged
merged 1 commit into from
Nov 7, 2013
Merged

Remove ruby version from Gemfile #602

merged 1 commit into from
Nov 7, 2013

Conversation

arthurnn
Copy link
Member

@arthurnn arthurnn commented Nov 1, 2013

It is not a good idea to have a ruby version on the Gemfile, specially if you are using RVM,
as rvm sets ENV[RUBY_VERSION] using the revision number: ex.: ruby-2.0.0-p247 , which does not work

review @shingara

It is not a good idea to have a ruby version on the Gemfile, specially if you are using RVM,
as rvm sets ENV[RUBY_VERSION] using the revision number: ex.: ruby-2.0.0-p247 , which does not work
@coveralls
Copy link

Coverage Status

Coverage increased (+0.77%) when pulling 929a2d1 on ruby_version into 39c486a on master.

@shingara
Copy link
Member

shingara commented Nov 4, 2013

I understand you concern about rvm. I not using rvm so I didn't know this issue. Sorry. I do this adding to force the usage of 2.0.0 in heroku. Maybe we can use another ENV variable instead of RUBY_VERSION and only if you use the HEROKU or USE_ENV variable set to true. like :

ruby (ENV['ERRBIT_RUBY_VERSION'] || '2.0.0') if ENV['HEROKU'] || ENV['USE_ENV']

in heroku the default ruby is 1.9.2 and it's not compatible to mongoid 3. So we can't deploy on heroku without change the Gemfile. But I want keep this simple deploiement on heroku behavior.

What do you think about this change ?

@arthurnn
Copy link
Member Author

arthurnn commented Nov 4, 2013

I think the default on heroku is 2.0.0 by now: https://blog.heroku.com/archives/2013/6/17/ruby-2-default-new-aps

@shingara
Copy link
Member

shingara commented Nov 7, 2013

Ok, I merge it. But we need delete some other information in documentation about that.

shingara added a commit that referenced this pull request Nov 7, 2013
Remove ruby version from Gemfile
@shingara shingara merged commit ca25b8b into master Nov 7, 2013
@shingara shingara deleted the ruby_version branch November 7, 2013 13:55
@arthurnn
Copy link
Member Author

arthurnn commented Nov 7, 2013

Ok, double checking the docs right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants