Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra queries on apps collection #603

Merged
merged 1 commit into from
Nov 4, 2013
Merged

Conversation

arthurnn
Copy link
Member

@arthurnn arthurnn commented Nov 1, 2013

Using the scope on apps controller will yield lots of queries, so we need to call .to_a

review @shingara

Using the scope on apps controller will yield lots of queries, so we need to call .to_a
@coveralls
Copy link

Coverage Status

Coverage increased (+0.77%) when pulling b0799e0 on remove_extra_apps_query into 39c486a on master.

@shingara
Copy link
Member

shingara commented Nov 4, 2013

ok, thanks with this performance improvement.

shingara added a commit that referenced this pull request Nov 4, 2013
Remove extra queries on apps collection
@shingara shingara merged commit 65b4b30 into master Nov 4, 2013
@arthurnn arthurnn deleted the remove_extra_apps_query branch November 4, 2013 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants