Handle App Version Value #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 8545071 on soberstadt:619-handle-app-version-value into * on errbit:master*. |
|
@michaelharro Made an initial commit, just to get the ball rolling some. Any thoughts? |
|
I initially put the version listed in the 'Summary' tab. |
|
Seems good to me. And you right. Thanks. |
|
@soberstadt does this implement the other half of the feature, "If the App Version is set on the project, then errors older than the project's app version will be ignored.", or does it just show the app version? |
|
@michaelharro it only shows you the app version as reported by the notice api. That part might be outside my capacity right now. Feeling ambitious? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Airbrake API docs:
It'd be cool to have this in Errbit for us using it for mobile apps.