Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give admins the ability to destroy all problems associated with an app #640

Merged
merged 1 commit into from Feb 19, 2014
Merged

Give admins the ability to destroy all problems associated with an app #640

merged 1 commit into from Feb 19, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2014

Due to some recent changes in errbit fingerprinting, my apps are littered with Problems that represent the same underlying error, but are not successfully clustered into different Errs of the same Problem by errbit.

I'd like to make fingerprinting more configurable (more to come later), but in the meantime I need to clean up my errbit apps, now that I have worked around the fingerprinting problem temporarily.

This feature is my attempt to enable admins to cleanup an app. It adds a "delete all errs" button to an app's edit screen that performs a one-shot destroy of all Problems. (The alternative is to page through hundreds or thousands of problems and use the selecct-all checkbox to delete each page worth of problems.)

A more elegant version of this feature would avoid adding an admin-only action, and instead would modify the table-select functionality of errbit so that the "select all" checkbox could be made to apply to all selected problems regardless of which page of search results they appear on.

Comments about this proposal, or about the more elegant proposal, are welcome.

@ghost
Copy link
Author

ghost commented Jan 22, 2014

Another solution to this problem is prototyped here:

https://github.com/tony-spataro-rs/errbit/tree/problem_bulk_actions_across_pages

The downside of this solution, is that is does not behave nicely with very large result sets. It "cheats" and embeds a complete list of results in every page of the paginated table view.

@shingara
Copy link
Member

This feature is good.

About the other feature it can be interesting too. So add another pull request please.

Thanks

shingara added a commit that referenced this pull request Feb 19, 2014
Give admins the ability to destroy all problems associated with an app
@shingara shingara merged commit 6b9914b into errbit:master Feb 19, 2014
@shingara shingara added this to the 0.3.0 milestone Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant