Allow users of a specific GitHub organization to login #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via their organization ID
Heroku config is stored as strings, fails to compare against ints
|
Updating |
|
Why do we need the github gem? could we just use the octokit one as already included. |
|
Yea, I somehow missed that Octokit was in there. I'll replace the current github_api code with octokit. |
|
@arthurnn, would you prefer to have the last commit in it's own PR for cleanliness? |
|
If you could squash all commits in one, and make ci pass would be awesome.. thanks |
|
Closing this in favor of #644. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
GITHUB_ORG_IDis set inENV, and someone attempts to login via GitHub without a prior account, one is automatically created for them. This is both convenient and secure, by not necessitating an administrator to create accounts for every user before they can login. It also restricts via the organization ID to prevent non-organization members from creating accounts. After creating their account they can choose to edit their profile to an email different than their GitHub one.