Upgrade from Octokit 1x to 2x to resolve issues with oauth2 #649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some issues with github and oauth2 when users had 2 factor auth enabled. I wasn't able to track down the exact cause of the errors unfortunately, however I was able to confirm
1.25
and the2.7.1
affect our use of itTo reproduce the error I was experiencing simply pop a rails console
I have a hunch that it has to do with 2 factor auth but I do not yet have facts to back that up.