Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Google Oauth2 authentication #733

Closed
wants to merge 4 commits into from
Closed

Adds Google Oauth2 authentication #733

wants to merge 4 commits into from

Conversation

pallan
Copy link

@pallan pallan commented Sep 23, 2014

This is a WIP branch to add Google Oauth2 integration to the application. It attempts to mimic the manner in which GitHub is integrated and as a result causes some duplication of code. In its current state Google Oauth does work once you have the client key and secret configured.

I created this PR to try to get feedback and some help to finish this off

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) when pulling d15ca255420bca76ea1881b0e2e4bb74e23a8d39 on pallan:omniauth into d50a69c on errbit:master.

@stevecrozz-
Copy link

Nice idea. Is your intention to automatically create an errbit account for anyone who has a google account? I wouldn't want that, but I'm interested in your particular use case. Maybe you do want that.

@pallan
Copy link
Author

pallan commented Sep 23, 2014

Our use case is that we use "Google Apps for Work" (or Business or whatever the new name is) to manage our organization. We use the OAuth provided by it to auth against a lot of our systems. This allows us to do the same thing with errbit.

As such, there is probably a couple more config variables that can be thrown in to enforce restricting it to our organization.

@arthurnn
Copy link
Member

Is this good to be merged? @pallan anything else you need here?

@pallan
Copy link
Author

pallan commented Jan 30, 2015

It looks like I will have to resolve some merge conflicts. Plus I think there are a couple of missing tests that I wanted to address. I will try to have that all ready for you next week.

@pallan pallan closed this Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants