Fix double escaping of problem title in list view

[felixbuenemann]

Without this change, the truncated text, which is already html escaped gets escaped again in the map block.

[TeatroIO]

I've prepared a stage. Click to open.

[shingara]

Have you a failure example ? This PR can introduce some security issue too :(

[felixbuenemann]

@shingara how can it introduce a security issue? The text is always escaped in the map block using the h helper. So because truncate already adds html escaping, content is escaped twice.
Eg. ' -> ' -> '

[shingara]

ok, you right.

[arthurnn]

Can you add a test case for this? thanks

[felixbuenemann]

OK, added a spec to check for double escaping that will fail without the changes:

Failures:

  1) ProblemsHelper#truncated_problem_message does not double escape html
     Failure/Error: expect(truncated).to_not include('&')
       expected "#<​NoMet​hodEr​ror: ​...&g​t;" not to include "&"
     # ./spec/helpers/problems_helper_spec.rb:16:in `block (3 levels) in <top (required)>'

You can test by setting truncate(…, escape: true) in truncated_problem_message.

[shingara]

great thanks 👍

[arthurnn]

awesome. thanks!