Fix success handling for update_repos #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the switch to python git, the success case handling was reversed even though `0` was still meant to indicate success (formerly used to represent process exited without error). errbotio@89bce02#diff-b279f20d61152a2a99689009a59d70609c92039568c203da8c84bb56ceacd94fR287 This pull request fixes that issue and makes the code a bit more clear by using booleans rather than integers to represent the success state.
|
Thank you! |
sijis
added a commit
that referenced
this pull request
Jun 11, 2022
* Fix success handling for update_repos As part of the switch to python git, the success case handling was reversed even though `0` was still meant to indicate success (formerly used to represent process exited without error). 89bce02#diff-b279f20d61152a2a99689009a59d70609c92039568c203da8c84bb56ceacd94fR287 This pull request fixes that issue and makes the code a bit more clear by using booleans rather than integers to represent the success state. * docs: Add fixes to CHANGES Co-authored-by: Sijis Aviles <sijis.aviles+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the switch to python git, the success case handling was reversed even though
0was still meant to indicate success (formerly used to represent process exited without error).89bce02#diff-b279f20d61152a2a99689009a59d70609c92039568c203da8c84bb56ceacd94fR287
This pull request fixes that issue and makes the code a bit more clear by using booleans rather than integers to represent the success state.