fix: tests on test backend #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also address a small typo in attribute check in open_storage()
This should workaround a thread and storage timing problem.
sijis
force-pushed
the
tests/test_backend
branch
from
672bbac
to
ededb23
Compare
sijis
added a commit
that referenced
this pull request
Jun 11, 2022
* refactor: logic if storage plugin is open/closed Also address a small typo in attribute check in open_storage() * refactor: split test backend shutdown sequence This should workaround a thread and storage timing problem. * fix: move bot_thread to init * test: disable failed circular dependency test * docs: add test fixes to CHANGES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring the shutdown sequence in test backend to address failing tests.