Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Git Action only on workflow SUCCESS #29

Closed
GemmaTuron opened this issue Jun 21, 2023 · 1 comment
Closed

Run Git Action only on workflow SUCCESS #29

GemmaTuron opened this issue Jun 21, 2023 · 1 comment

Comments

@GemmaTuron
Copy link
Member

Currently, we are running actions based on workflow completion, in the following order:

  1. Model Test
  2. Update to S3
  3. Update to DockerHub

The workflow completion does not mean that it will run only if the workflow has succeeded, it runs in any case, which then makes the pipeline useless since models that fail the test will still be on DockerHub.
I have been playing with this model (eos7pw8) to find the right combination of if statements. We need to add the following if statement on the Update to S3 and Update to DockerHub:
if: ${{ github.event.workflow_run.conclusion == 'success' }}
And if we want both statements (the one we had and this new one) This should be the syntax:
${{ github.repository != 'ersilia-os/eos-template' && github.event.workflow_run.conclusion == 'success' }}
You can see how it works in this pipeline of actions

@GemmaTuron GemmaTuron changed the title Run Gtit Action only on workflow SUCCESS Run Git Action only on workflow SUCCESS Jun 21, 2023
@GemmaTuron
Copy link
Member Author

I've updated the relevant workflow files (commits #118 and #119)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant