Skip to content
This repository has been archived by the owner on Aug 10, 2023. It is now read-only.

Dockerized and Refactored the model #20

Merged
merged 6 commits into from
Aug 1, 2023
Merged

Dockerized and Refactored the model #20

merged 6 commits into from
Aug 1, 2023

Conversation

samuelmaina
Copy link
Collaborator

No description provided.

@samuelmaina
Copy link
Collaborator Author

HI @GemmaTuron ,
Can you have a look at this PR.

@GemmaTuron
Copy link
Member

@samuelmaina
I think it all looks good but could you eliminate the mock.csv file and the .DS_STORE (legacy from pushing from a Mac) files?
Also the Mock csv is the only git lfs tracked object, so this could be deleted

@samuelmaina
Copy link
Collaborator Author

Hi @GemmaTuron ,
The model failed due to the ersilia intallation problem. When you solve the issue, this model is affected.

@GemmaTuron
Copy link
Member

Update: we are working on the ersilia install issue, we will merge this PR once solved: ersilia-os/ersilia#753

@GemmaTuron GemmaTuron merged commit dd5072f into ersilia-os:main Aug 1, 2023
2 of 3 checks passed
@samuelmaina
Copy link
Collaborator Author

Hi @GemmaTuron ,
I will also update the workflows for this.

@GemmaTuron
Copy link
Member

Hi @samuelmaina

The workflows are updated already, I have assigned model testing ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants