Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the service class method to the modelcard #1173

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

Malikbadmus
Copy link
Contributor

@Malikbadmus Malikbadmus commented Jun 25, 2024

Related to this (comment)[https://github.com//issues/1072#issuecomment-2185852513]

Description

Make ersilia catalog --local --more verbose in its output including information about how the model was fetched.

Changes made

  • Added get_service_class method to the Localcard class in card.py.
  • Added service_class method to the Modelcard.
  • Added a series of private method to get the status, input and output type of a model in catalog.py.
  • Modified Local to display this new additional information.

Status

  • Old model local catalog output
[
    {
        "Identifier": "eos4wt0",
        "Slug": "morgan-fps",
        "Title": "Morgan Fingerprints"
    },
    {
        "Identifier": "eos30f3",
        "Slug": "dmpnn-herg",
        "Title": "Prediction of hERG Channel Blockers with Directed Message Passing Neural Networks"
    },
    {
        "Identifier": "eos4se9",
        "Slug": "smiles2iupac",
        "Title": "STOUT: SMILES to IUPAC name translator"
    },
    {
        "Identifier": "eos3b5e",
        "Slug": "molecular-weight",
        "Title": "Molecular weight"
    }
]
  • New model local catalog output
[
    {
        "Identifier": "eos4wt0",
        "Slug": "morgan-fps",
        "Title": "Morgan Fingerprints",
        "Status": "Ready",
        "Input": "Compound",
        "Output": "Descriptor",
        "Service Class": "pulled_docker"
    },
    {
        "Identifier": "eos30f3",
        "Slug": "dmpnn-herg",
        "Title": "Prediction of hERG Channel Blockers with Directed Message Passing Neural Networks",
        "Status": "Ready",
        "Input": "Compound",
        "Output": "Score",
        "Service Class": "pulled_docker"
    },
    {
        "Identifier": "eos4se9",
        "Slug": "smiles2iupac",
        "Title": "STOUT: SMILES to IUPAC name translator",
        "Status": "Ready",
        "Input": "Compound",
        "Output": "Text",
        "Service Class": "pulled_docker"
    },
    {
        "Identifier": "eos3b5e",
        "Slug": "molecular-weight",
        "Title": "Molecular weight",
        "Status": "Ready",
        "Input": "Compound",
        "Output": "Other value",
        "Service Class": "pulled_docker"
    }
]

Related to #1072

@Malikbadmus
Copy link
Contributor Author

Malikbadmus commented Jun 25, 2024

@DhanshreeA , this is the output now, added four (4) additional information to it.

Result

@DhanshreeA
Copy link
Member

DhanshreeA commented Jun 26, 2024

@DhanshreeA , this is the output now, added four (4) additional information to it.

Result

Not endorsing screen shots but the output looks good to me! :)

ersilia/hub/content/card.py Outdated Show resolved Hide resolved
ersilia/hub/content/card.py Show resolved Hide resolved
@DhanshreeA
Copy link
Member

Hey @Malikbadmus great work! Thank you. Few small comments but we can absolutely merge this today.

@DhanshreeA DhanshreeA closed this Jun 26, 2024
@DhanshreeA DhanshreeA reopened this Jun 26, 2024
@Malikbadmus
Copy link
Contributor Author

Hey @Malikbadmus great work! Thank you. Few small comments but we can absolutely merge this today.

Changes applied.

@DhanshreeA
Copy link
Member

LGTM!

@DhanshreeA DhanshreeA merged commit 0f7e968 into ersilia-os:master Jun 26, 2024
16 checks passed
@Malikbadmus Malikbadmus deleted the catalog branch June 26, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants