Test and workflows to check readme file changes on master #210
Conversation
|
I am looking into the error but what I feel is since the superior branch is named 'master', the issue arises as it works for a superior branch named 'main' |
|
Hi @sayantani11 this is great stuff. Do you think we should rename master to main? (master is old nomenclature in github as you may know). I am afraid of doing so at this stage because many people are currently contributing to ersilia and this may cause problems. What are your thoughts? |
Yes, it can create a chaos for the people who are new to git as well. So what I feel is we can hold this for now!! And after 20th we can focus on renaming the branch for this.... As it will be just two more days of the contribution period. What say? |
|
Completely agree with you. Let's keep this on hold |
|
@miquelduranfrigola Can you rename the branch? |
|
Hi @sayantani11, We are making some changes to the repository structure, including creating a Docker image for it, so we will rename the branch when we release all these new features. Then we will merge the PR as well. |
|
@GemmaTuron this pull request is very interesting. Can we please try to merge it, or at least learn the relevant GitHub Actions contributed? |
|
@GemmaTuron any progress here? |
| git fetch origin master:master | ||
| git diff --name-only master $HEAD > modified | ||
| echo "these files have changed" | ||
| cat modified |
There was a problem hiding this comment.
if this is a huge file , it will basically do a long print with cat, I wouldn't suggest to print it out in a setup as it's not a part of setup.
|
|
||
| jobs: | ||
| Setup: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
not sure if this repos maintainers plan to maintain for latest ubuntu or for a specific version. from the docker file it seems to be using ubuntu 20.04.
@miquelduranfrigola : can you confirm against which image the test should be run ?
There was a problem hiding this comment.
Hi! ubuntu-latest is good in my opinion!
|
@GemmaTuron I am trying to resolve this issue but I am running into conflicts at the moment. Can you please check? |
|
Hey, since @sayantani11 is participating in this round, this might be a good moment to close the issue. |
|
@GemmaTuron @miquelduranfrigola I can actually look into this issue again! And try to figure what's the problem maybe |
|
Sorry, I overlooked this PR - my apologies. @sayantani11 is doing amazing work on other fronts. So, @sayantani11 - if you have time to work on it, great. If not, I would deprioritise this PR for now. |
Fixes #177