Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an empty folder in the ersilia project with the name 'tutorial' #32

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

kbetty
Copy link
Contributor

@kbetty kbetty commented Mar 27, 2022

No description provided.

@GemmaTuron GemmaTuron merged commit 5fce52d into ersilia-os:master Mar 27, 2022
@kbetty
Copy link
Contributor Author

kbetty commented Mar 27, 2022

Thank you @GemmaTuron ! This is interesting to see my first contribution in open source has been merged. I want to learn more by working on other tasks.

@Kcfreshly
Copy link
Contributor

@kbetty @GemmaTuron I think we need to change the description used in the commit when creating the Tutorial folder.

I suggest

-Adding an empty folder in the ersilia project with the name 'tutorial' 
+Tutorial or Ersilia Model Hub Tutorial

@kbetty
Copy link
Contributor Author

kbetty commented Mar 29, 2022

Thanks @Kcfreshly for the suggestion. I think the commit message that I suggested is fine however, your suggestion is fine too.
I think since the PR is already merged, we can go with the one that was suggested in the commit. cc: @GemmaTuron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants