Skip to content

Commit

Permalink
Test on PHP and HHVM nightly builds
Browse files Browse the repository at this point in the history
  • Loading branch information
@hkdobrev
hkdobrev committed Mar 4, 2015
1 parent d5bca42 commit 12bf1c6
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
language: php

php:
- 7

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Mar 8, 2015

should be 7.0

This comment has been minimized.

Sign in to view

Copy link
@hkdobrev

hkdobrev Mar 8, 2015

Author Contributor

@GrahamCampbell Why?

This comment has been minimized.

Sign in to view

Copy link
@hkdobrev

hkdobrev Mar 8, 2015

Author Contributor

@GrahamCampbell 7 or 7.0 is aliased to nightly. I imagine this should be changed several times as alpha, beta RC and stable releases of PHP are released. As a I think of it more, it should be nightly actually.

  1. It is more explicit. And people could see what actually is used. It would not be hard to imagine nightly is for PHP 7.
  2. It would need to be changed again, but at least nightly could always stay as-is and just add stable versions as they are released.

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Mar 8, 2015

7.0 makes more sense otherwise when 7.1 dev releases start, we suddenly find we're no longer testing against 7.0, which is what we want to be testing against. Config should always be made future proof. The current aliases are not relevant.

This comment has been minimized.

Sign in to view

Copy link
@hkdobrev

hkdobrev Mar 8, 2015

Author Contributor

@GrahamCampbell Do you agree with my arguments above about using only nightly at this point and changing it to such configuration at the moment: https://github.com/hkdobrev/parsedown/blob/nightly/.travis.yml

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Mar 8, 2015

Nah, I think adding "7.0" is better. Testing on "nightly" is probably overkill.

This comment has been minimized.

Sign in to view

Copy link
@hkdobrev

hkdobrev Mar 8, 2015

Author Contributor

@GrahamCampbell

The current aliases are not relevant.

Exactly!

7.0 is aliased to nightly. When you write 7.0 you are actually testing on the nightly build. You are not testing on the tagged version of PHP 7.0.

This comment has been minimized.

Sign in to view

Copy link
@GrahamCampbell

GrahamCampbell Mar 8, 2015

No, but in the future you will be, that's my entire point.
- 5.6
- 5.5
- 5.4
- 5.3
- hhvm
- hhvm-nightly

matrix:
allow_failures:
- php: 7
- php: hhvm-nightly

install:
- composer selfupdate
Expand Down

0 comments on commit 12bf1c6

Please sign in to comment.