Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust version constant to 1.7.0 #556

Closed
wants to merge 1 commit into from

Conversation

stefandoorn
Copy link

No description provided.

@PhrozenByte
Copy link
Contributor

Since merging this would require tagging a new release the version constant should rather be 1.7.1 or something 😉

@stefandoorn
Copy link
Author

Haha indeed :-)

@stefandoorn stefandoorn deleted the patch-2 branch February 28, 2018 16:35
@scottchiefbaker
Copy link

scottchiefbaker commented Feb 28, 2018

This does need to get addressed. The version constant has been out of whack for quite a while now. Even when 1.6.1 was released it's always said 1.6.0. I have a tool that reads this version string, so it's important to me.

@aidantwoods
Copy link
Collaborator

I think it should be possible to parse git describe --tags in Travis to detect if it is a release commit and compare against the hard coded version so the build would at least fail if the number doesn't get updated. It would be nice to get this to auto-update as part of the release process too really

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants