Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service_id and plan_id checks #151

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

redorff
Copy link
Contributor

@redorff redorff commented May 4, 2021

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.06%) to 95.745% when pulling 5b468e0 on redorff:service_id_and_plan_id_checks into 32b5e13 on eruvanos:main.

@redorff
Copy link
Contributor Author

redorff commented Aug 6, 2021

Hello Maic.
I hope you are going well.
I tried to submit a few merge requests a few weeks ago.
Have you had time to review them?
If something is wrong, please tell me and I'll do my best to fix it.
Best regards.

@eruvanos
Copy link
Owner

Hello Maic. I hope you are going well. I tried to submit a few merge requests a few weeks ago. Have you had time to review them? If something is wrong, please tell me and I'll do my best to fix it. Best regards.

Hi, thanks for the contribution, I was a little bit busy regarding another open source project.
I merged your two pull requests and will have a look into this one as well.
Greetings

@redorff
Copy link
Contributor Author

redorff commented Oct 14, 2021

Great to see you back on this project! :)
Don't worry, I will resolve the conflicts...
I also have many more evolutions to submit...
By the way, what do you think of "black", the code formatter? I started using it on my fork... I think it's pretty good...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants