ARC: The eviction event-handler is not called when manually removing an entry

[erwanor]

Good: (simple.go)

func (c *SimpleCache) remove(key interface{}) bool {
	item, ok := c.store[key]
	if ok {
		delete(c.store, key)
		if c.evictedFunc != nil {
			c.evictedFunc(key, item.value)
		}
		return true
	}
	return false
}

This is the internal remove function. Let us walk through it:

1. We check if an entry is in the cache
2. If it is we remove it (delete(c.store, key))
3. We check if we have a defined eviction handler
4. If we do we call it
5. Otherwise we return

Bad:

func (c *ARC) Remove(key interface{}) bool {
	c.mu.Lock()
	defer c.mu.Unlock()

	elt, exists := c.store[key]
	if !exists {
		return false
	}

	if elt.parent != nil {
		elt.parent.Remove(elt.element)
	}

	delete(c.store, elt.key)
	c.size--
	return true
}

Goal: Make the good behavior consistent across the library