add support for additional salt.auth types #372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #367, @hoaivan requests the addition of auth method
sharedsecred
.However, that is not a safe mechanism unless additional measures are taken to prevent leaking these credentials.
Therefore
sharedsecret
will not be added as a standard option in the login screen.But here is an alternative...
A file
salt-auth.txt
can be placed on the server, which contains all of the additional auth methods that should be shown.So additional options will only be visible when they are added to that file.
And also, any other auth mechanism can be made selectable.
Note that an auth method does not work unless it is also configured in the
master
file.This PR replaces the original PR #367.