Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for additional salt.auth types #372

Merged
merged 4 commits into from
Aug 29, 2021
Merged

add support for additional salt.auth types #372

merged 4 commits into from
Aug 29, 2021

Conversation

erwindon
Copy link
Owner

@erwindon erwindon commented Aug 6, 2021

In #367, @hoaivan requests the addition of auth method sharedsecred.
However, that is not a safe mechanism unless additional measures are taken to prevent leaking these credentials.
Therefore sharedsecret will not be added as a standard option in the login screen.

But here is an alternative...
A file salt-auth.txt can be placed on the server, which contains all of the additional auth methods that should be shown.
So additional options will only be visible when they are added to that file.
And also, any other auth mechanism can be made selectable.

Note that an auth method does not work unless it is also configured in the master file.

This PR replaces the original PR #367.

@erwindon
Copy link
Owner Author

erwindon commented Aug 6, 2021

@hoaivan can you please give the code from this PR a try?

@erwindon
Copy link
Owner Author

@hoaivan I did not receive a reaction. can you still please try this PR?

@hoaivan
Copy link

hoaivan commented Aug 14, 2021

I will schedule my time for this.

@erwindon erwindon force-pushed the customeauth branch 3 times, most recently from 165dba6 to 9ec2794 Compare August 20, 2021 16:44
@erwindon
Copy link
Owner Author

@hoaivan do you have some time in the coming days? If not, I'll just trust my own testing and merge this PR.

@erwindon erwindon force-pushed the customeauth branch 2 times, most recently from d5b3f84 to 1d37777 Compare August 22, 2021 12:01
@erwindon
Copy link
Owner Author

erwindon commented Aug 29, 2021

@hoaivan it seems you are unavailable.

I've tested the updated login screen and:

  • it works properly with salt-auth.txt absent
  • it works properly with salt-auth.txt as an empty file
  • it works properly with salt-auth.txt containing only sharedsecret
  • it works properly with salt-auth.txt containing sharedsecret and xyz (though choosing xyz leads to nothing)

@erwindon erwindon merged commit ccea6c6 into master Aug 29, 2021
@erwindon erwindon deleted the customeauth branch August 29, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants