New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom command help - part deux #436

Merged

erwindon merged 3 commits into master from customhelp

Mar 28, 2022

Owner

erwindon commented Mar 25, 2022 •

edited

See also #432, which had technical problems
this is an exact re-implementation

erwindon self-assigned this

erwindon added enhancement work-in-progress PR and removed PR labels

Owner Author

erwindon commented Mar 25, 2022

decided to treat the custom-help-text as any other global setting and read it just after login.
(actually it was already collected but just not stored)
from then on the custom-help-text is available as a property in the session.
that makes it very easy to use...

Owner Author

erwindon commented Mar 25, 2022

@achimmihca FYI
this PR replaces your PR (and it also replaces the issue that I created unnecessarily).
can you please confirm that this implementation of "custom-help" works for you?

erwindon assigned erwindon and unassigned erwindon

Repository owner deleted a comment from sonarcloud bot

erwindon force-pushed the customhelp branch 4 times, most recently from e50990d to 0acdcbe Compare

March 26, 2022 10:43

achimmihca and others added 3 commits

March 27, 2022 00:42


          added button to show "custom command help" that is defined in salt ma…

0d024fb

…ster configuration


          simplified implementation of custom help

b199165


          added custom-help setting to the (hidden) options page

e8b0dbc

erwindon force-pushed the customhelp branch from 0acdcbe to e8b0dbc Compare

March 26, 2022 23:44

sonarcloud bot commented Mar 26, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Contributor

achimmihca commented Mar 28, 2022

Yes, works as desired. Thanks!

erwindon merged commit 43ccd62 into master

erwindon deleted the customhelp branch

March 28, 2022 08:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment