Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone conversion issues #488

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Timezone conversion issues #488

merged 1 commit into from
Jan 12, 2023

Conversation

erwindon
Copy link
Owner

Describe the bug
As seen in the attached screenshot below (done on Firefox on Windows Server 2019), the timestamp in the white below the job name shows 1:24 EDT, while the output within the black output shows the timestamp as 9:24 EDT. That matches the 4 hour difference that EDT applies to UTC (UTC-4).

Screenshots
image

Additional context
New issue stemming out of testing for #485

@erwindon
Copy link
Owner

welcome back! good that you treat this as a separate issue.
I don't have the opportunity to act on this one as quickly as the previous one. please be patient...

In the image I see another small issue: the field "__state_ran__" is superfluous and should be hidden. In general SaltGUI keeps the details from the states small by eliminating trivial information. e.g. something that you don't see is the duration of second task because it was less than 10 milliseconds (but it is still counted for the total duration).

@erwindon
Copy link
Owner

changed to PR
first commit is only about 'state_ran'

@mkbrown
Copy link
Author

mkbrown commented Oct 25, 2022

state_ran is now hidden, so first commit works as intended. No worries on the issue itself; just reporting it since I'm in the weeds. I'm teaching myself salt for work stuff, and porting Puppet and Ansible code to it, so lots to keep myself amused... ;-p

Have a great week!

/Mike

@erwindon erwindon closed this Oct 26, 2022
@github-pages github-pages bot temporarily deployed to github-pages October 26, 2022 23:03 Inactive
@erwindon erwindon reopened this Oct 26, 2022
@erwindon
Copy link
Owner

cherry-picked the commit for "state_ran" to the main branch
restarted this PR with an empty branch (that confused github a bit, but the PR is open again)

@erwindon
Copy link
Owner

the field "start_time" (on task level) is implemented by SaltStack as a local-time.
but field "StartTime" (on job level) is derived from the job-id, which is implemented by SaltStack as utc-time.

@erwindon erwindon closed this Nov 2, 2022
@erwindon erwindon deleted the task_info branch November 2, 2022 00:26
@erwindon erwindon reopened this Nov 7, 2022
@erwindon
Copy link
Owner

erwindon commented Nov 7, 2022

(re-opened after accidental close)

@erwindon erwindon force-pushed the task_info branch 2 times, most recently from 5ebe8a4 to 380a916 Compare November 12, 2022 21:55
@erwindon erwindon force-pushed the task_info branch 3 times, most recently from 9bf3930 to 7604010 Compare November 19, 2022 21:52
@erwindon erwindon force-pushed the task_info branch 2 times, most recently from 1df6815 to 08f0546 Compare January 8, 2023 13:30
Repository owner deleted a comment from sonarcloud bot Jan 8, 2023
@erwindon erwindon force-pushed the task_info branch 5 times, most recently from 00daa20 to 472de4f Compare January 8, 2023 17:12
@erwindon erwindon force-pushed the task_info branch 2 times, most recently from f01d932 to 76ac441 Compare January 8, 2023 20:32
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@erwindon erwindon merged commit 5e9e74c into master Jan 12, 2023
@erwindon erwindon temporarily deployed to github-pages January 12, 2023 20:51 — with GitHub Pages Inactive
@erwindon erwindon restored the task_info branch January 12, 2023 21:17
@erwindon erwindon deleted the task_info branch January 12, 2023 21:24
@erwindon
Copy link
Owner

added information line at the top of the high-state output to inform user of interpretation of the timestamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants