Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of plato (1.7.0) using a vulnerable version of lodash (4.13.1) #216

Open
AlfredoPardo-zz opened this issue Sep 5, 2018 · 6 comments

Comments

@AlfredoPardo-zz
Copy link

Hi Everyone,

When running a custom static-code analysis tool, we've found that plato 1.7.0 has lodash 4.13.1 within its dependencies, which is known to have a "Prototype Pollution" vulnerability.

More information here

Thank you,

Alfredo Pardo

@JaneX8
Copy link

JaneX8 commented Nov 16, 2018

From: https://nodesecurity.io/advisories/577

Versions of lodash before 4.17.5 are vulnerable to prototype pollution.

The vulnerable functions are 'defaultsDeep', 'merge', and 'mergeWith' which allow a malicious user to modify the prototype of Object via proto causing the addition or modification of an existing property that will exist on all objects.

Remediation
Update to version 4.17.5 or later.

@jsoverson Please fix this.

> npm audit


                       === npm audit security report ===


                                 Manual Review
             Some vulnerabilities require your attention to resolve

          Visit https://go.npm.me/audit-guide for additional guidance


  Low             Prototype Pollution

  Package         lodash

  Patched in      >=4.17.5

  Dependency of   plato [dev]

  Path            plato > lodash

  More info       https://nodesecurity.io/advisories/577

found 1 low severity vulnerability in 19605 scanned packages
  1 vulnerability requires manual review. See the full report for details.

@JaneX8
Copy link

JaneX8 commented Nov 21, 2018

@jsoverson any chance we can update the dependency to >=4.17.5?

@JaneX8
Copy link

JaneX8 commented Dec 5, 2018

@jsoverson sorry for the direct mentioning again. But any chance we can update the dependency to >=4.17.5 for the matter of security?

@ainthek
Copy link

ainthek commented Feb 7, 2019

+1 please

@jsoverson
Copy link
Member

I totally understand the desire but I'm hesitant to accept and publish any changes because it makes this project appear maintained when it isn't. This project needs active maintainers and there aren't any. If there is a fork that has been generally accepted as the-next-best-repo then I can link to it in the readme.

@ainthek
Copy link

ainthek commented Feb 7, 2019 via email

kyungilpark added a commit to kyungilpark/plato that referenced this issue Jun 29, 2019
### REASON
vulnerability issue (es-analysis#216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants