Skip to content

Commit

Permalink
No reason to exclude node 0.4.
Browse files Browse the repository at this point in the history
  • Loading branch information
@ljharb
ljharb committed Jan 26, 2014
1 parent b60fc60 commit 9c043a1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .travis.yml
View file
Expand Up @@ -4,6 +4,7 @@ node_js:
- "0.10" - "0.10"
- "0.8" - "0.8"
- "0.6" - "0.6"
- "0.4"

This comment has been minimized.

Sign in to view

Copy link
@Raynos

Raynos Feb 1, 2014

Contributor

wut. Node 0.4 & 0.6 are dead & unmaintained. They should stay dead

This comment has been minimized.

Sign in to view

Copy link
@ljharb

ljharb Feb 1, 2014

Author Member

Providing an upgrade path, even from old unmaintained versions (node, browser, or otherwise) is part of a module maintainer's responsibility imo. Of course nobody should be using anything but the latest node stable - but there are still production systems using old versions of node, and it harms nothing to ensure tests still pass in them.
before_install: before_install:
- '[ "${TRAVIS_NODE_VERSION}" != "0.6" ] || npm conf set strict-ssl false' - '[ "${TRAVIS_NODE_VERSION}" != "0.6" ] || npm conf set strict-ssl false'


2 changes: 1 addition & 1 deletion package.json
View file
Expand Up @@ -37,7 +37,7 @@
"uglify-js": "~2.4.12" "uglify-js": "~2.4.12"
}, },
"engines": { "engines": {
"node": ">=0.6.0" "node": ">=0.4.0"
}, },
"testling": { "testling": {
"browsers": [ "browsers": [
Expand Down

0 comments on commit 9c043a1

Please sign in to comment.