-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Luksan vlcek1 and gradient utils #69
Conversation
namespace pagmo | ||
{ | ||
|
||
/// Test problem from the Luksan and Vlcek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just from
instead of from the
.
* | ||
* @param dim the problem dimensions. | ||
* | ||
* @throw std::invalid_argument if \p dim is < 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing period
#define PAGMO_PROBLEM_LUKSANVLCECK_HPP | ||
|
||
#include <cassert> | ||
#include <exception> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this header is not used (for std::invalid_argument
you need stdexcept
, which is included below).
#define PAGMO_PROBLEM_LUKSANVLCECK_HPP | ||
|
||
#include <cassert> | ||
#include <exception> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <cmath>
* | ||
* It returns the box-bounds for this UDP. | ||
* | ||
* @return the lower and upper bounds for each of the decision vector components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MP
pygmo/docstrings.cpp
Outdated
@@ -2805,6 +2838,124 @@ Complexity is :math:`\mathcal{O}(MN)` where :math:`M` is the number of objective | |||
)"; | |||
} | |||
|
|||
std::string estimate_sparsity_docstring() | |||
{ | |||
return R"(estimate_sparsity_docstring(callable, x, dx = 1e-8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra _docstring
pygmo/docstrings.cpp
Outdated
|
||
std::string estimate_gradient_docstring() | ||
{ | ||
return R"(estimate_gradient_docstring(callable, x, dx = 1e-8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
pygmo/docstrings.cpp
Outdated
|
||
std::string estimate_gradient_h_docstring() | ||
{ | ||
return R"(estimate_gradient_docstring(callable, x, dx = 1e-8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
* \end{array} | ||
* \f] | ||
* | ||
* See: Lukšan, L., and Jan Vlcek. "Sparse and partially separable test problems for unconstrained and equality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would check if the "š" character survives intact in the doxygen -> sphinx transition. If it does, I'd use it consistently (elsewhere a normal "s" is used).
pygmo/docstrings.cpp
Outdated
+4x_{k+1}-x_k\exp(x_k-x_{k+1})-3 \ge LB, \forall k=1..n-2 \\ | ||
\end{array} | ||
|
||
See: Lukšan, L., and Jan Vlcek. "Sparse and partially separable test problems for unconstrained and equality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here regarding the "š" character. We should check whether it shows up correctly in the final sphinx docs and use it consistently.
[skip ci] forgotten from #69
The first gradientfull scalable problem in pagmo. And some numerical derivation utils