Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS paper setup #7

Merged
merged 6 commits into from
Aug 14, 2023
Merged

JOSS paper setup #7

merged 6 commits into from
Aug 14, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jul 3, 2023

Adding initial files for the JOSS submission

@gomezzz gomezzz requested a review from schuhmaj July 3, 2023 03:07
@gomezzz gomezzz mentioned this pull request Jul 7, 2023
Merged
4 tasks
@gomezzz
Copy link
Collaborator Author

gomezzz commented Aug 11, 2023

@schuhmaj can we merge this? :) #9 builds on it, I think

schuhmaj
schuhmaj requested changes Aug 13, 2023
View reviewed changes
Copy link
Collaborator

@schuhmaj schuhmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the citation correct? Otherwise fine.

Anyway, Many thanks for setting this up 👍😀

paper/paper.bib Show resolved Hide resolved
@gomezzz gomezzz requested a review from schuhmaj August 14, 2023 08:30
schuhmaj
schuhmaj approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@schuhmaj schuhmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@gomezzz gomezzz merged commit 93e4845 into main Aug 14, 2023
3 checks passed
@gomezzz gomezzz deleted the joss-paper-setup branch August 14, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuhmaj schuhmaj schuhmaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gomezzz @schuhmaj