Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not move to previous screen #56

Closed
pavecho opened this issue Jun 22, 2017 · 15 comments
Closed

Can not move to previous screen #56

pavecho opened this issue Jun 22, 2017 · 15 comments

Comments

@pavecho
Copy link

pavecho commented Jun 22, 2017

I pressed the back button at folderMode(false).
It will not go back to the previous screen.

ImagePicker.create(this)
.returnAfterFirst(true)
.folderMode(false)
.multi()
.limit(10)
.showCamera(false)
.enableLog(false)
.start(PICK_IMAGE_MULTIPLE);

@dmmajithia
Copy link

I'm having the same problem!
Is this because I'm testing it on the emulator?

@AnthonyEd
Copy link

I have the same problem, I even tested it on a real phone still the same.

@mihudevcom
Copy link

The issue is in ImagePickerActivity:

@Override public void onBackPressed() { if (!recyclerViewManager.isDisplayingFolderView()) { setFolderAdapter(null); return; } setResult(RESULT_CANCELED); super.onBackPressed(); }

I can take care of it this week if the owner lets me. What do you think @esafirm ?

@esafirm
Copy link
Owner

esafirm commented Jul 3, 2017

@mihudevcom please do! 🙏

@yarodevuci
Copy link

@mihudevcom what is recyclerViewManager

@mihudevcom
Copy link

@yarodevuci Not 100% sure yet since i didn't go into details. I just took a fast look and since the bug is related to the back button and you can't go back than it's very possible that in the onBackPressed is the problem.

@yarodevuci
Copy link

I did this .returnAfterFirst(false), fixed my problem @mihudevcom

@mihudevcom
Copy link

@yarodevuci I'm using 1.7.2 with that option on and still have the problem. What version are you using?

@yarodevuci
Copy link

@mihudevcom same latest version

@mihudevcom
Copy link

@pavecho @AnthonyEd @dmmajithia What versions are you guys using?

@esafirm
Copy link
Owner

esafirm commented Jul 4, 2017

@mihudevcom it's definitely in onBackPressed
Would you mind if i trying solve this problem today instead? Thanks

@mihudevcom
Copy link

@esafirm Of course not. Go ahead. :)

@esafirm
Copy link
Owner

esafirm commented Jul 4, 2017

@mihudevcom @pavecho @dmmajithia @AnthonyEd
Can anyone confirm the fix? it's in

com.github.esafirm.android-image-picker:imagepicker:1.7.3-beta-1

Cheers!

@pavecho
Copy link
Author

pavecho commented Jul 4, 2017

It was fixed! Thanks @esafirm

@esafirm
Copy link
Owner

esafirm commented Jul 5, 2017

@pavecho You're welcome
Promoted to release 🎉
https://github.com/esafirm/android-image-picker/releases/tag/1.7.3

@esafirm esafirm closed this as completed Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants