This repository was archived by the owner on Jan 30, 2026. It is now read-only.
Fulfill the promise only after last stream is written - #9
Merged
Conversation
When we have a chained pipe operation of N streams, we know we are done when the last stream emits the 'finish' event, which means data has been flushed to the media and the end() method was called. An error on any stream should reject the promise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we have a chained pipe operation of N streams, we know we are done
when the last stream emits the 'finish' event, which means data has been
flushed to the media and the end() method was called.
An error on any stream should reject the promise.