Does not build with tests out of the box

[meg23]

From eofte...@gmail.com on September 03, 2009 03:40:07

What steps will reproduce the problem? 1. Download trunk
2. Try to run the maven build What is the expected output? What do you see instead? I expect it to build and all tests to pass What version of the product are you using? On what operating system? trunk on winxp Please provide any additional information below. I know about: http://www.owasp.org/index.php/ESAPI-Building But in my opinion that is not good enough. The unit tests are not working,
which does not give me confidence in the product. Not sure if it's realted
but the pom.xml contains a file path to a local file
c:/users/jwilliams/desktop/keystore

Original issue: http://code.google.com/p/owasp-esapi-java/issues/detail?id=30

[meg23]

From mikael....@gmail.com on September 03, 2009 00:53:34

I have the same problems on Ubuntu 9.04. The massive amount of sysouts and hard coded
c:\ are quite annoying.

[meg23]

From pstho...@gmail.com on October 01, 2009 08:12:03

Not to pile on, but I just want to point out where we're at. With a fresh checkout
from trunk, I see 26 failures/errors.

Checkout of trunk as of sept 30th (but added beanshell to get it to build; that fix
is now in)

Failed tests:
testGetStateFromEncryptedCookie(org.owasp.esapi.reference.HTTPUtilitiesTest)
testSaveStateInEncryptedCookie(org.owasp.esapi.reference.HTTPUtilitiesTest)
testRedirectBeanShellRule(org.owasp.esapi.waf.BeanShellTest)
testBadContentType(org.owasp.esapi.waf.RestrictContentTypeTest)
testCreateSafeFileURIConstructor(org.owasp.esapi.reference.SafeFileTest)
testBadContentType(org.owasp.esapi.waf.RestrictContentTypeTest)
testSetup(org.owasp.esapi.reference.accesscontrol.policyloader.ACRPolicyFileLoaderTest)
testRedirectBeanShellRule(org.owasp.esapi.waf.BeanShellTest)
testExecuteUnixSystemCommand(org.owasp.esapi.reference.ExecutorTest)
testDecrypt(org.owasp.esapi.reference.EncryptorTest)
testGetValidDirectoryPath(org.owasp.esapi.reference.ValidatorTest)
testIsInvalidFilename(org.owasp.esapi.reference.ValidatorTest)
testIsValidDirectoryPath(org.owasp.esapi.reference.ValidatorTest)
testIsValidFileUpload(org.owasp.esapi.reference.ValidatorTest)

Tests in error:
testGoodUserAgent(org.owasp.esapi.waf.RestrictUserAgentTest)
testGetProperty(org.owasp.esapi.reference.EncryptedPropertiesTest)
testSetProperty(org.owasp.esapi.reference.EncryptedPropertiesTest)
testKeySet(org.owasp.esapi.reference.EncryptedPropertiesTest)
testStore(org.owasp.esapi.reference.EncryptedPropertiesTest)
testLoad(org.owasp.esapi.reference.EncryptedPropertiesTest)
testMain(org.owasp.esapi.reference.EncryptedPropertiesTest)
testGetResourceFile(org.owasp.esapi.reference.SecurityConfigurationTest)
testEncrypt(org.owasp.esapi.reference.EncryptorTest)
testSeal(org.owasp.esapi.reference.EncryptorTest)
testVerifySeal(org.owasp.esapi.reference.EncryptorTest)
testGetUserFromRememberToken(org.owasp.esapi.reference.AuthenticatorTest)

Tests run: 315, Failures: 14, Errors: 12, Skipped: 0

I'll start looking into these (I'm sure many are configuration or OS issues, but it
doesn't help convey the right message for ESAPI).

Attached full details in case anyone else wants them.

~PST

Attachment: ESAPI-out-of-the-box_fail-tests.zip

[meg23]

From neil.mat...@gmail.com on November 09, 2009 05:51:45

Attachment: ESAPI (3) 20091109-054805.xml

[meg23]

From chrisisbeef on December 01, 2009 21:45:34

I believe we are at a point where all tests pass now? I know they do in my environment

[meg23]

From schal...@darkmist.net on December 02, 2009 08:24:53

I know that all the JUnit tests are passing in Linux but I thought there were still
some that weren't in windows. My windows box is not reachable right now or I'd test
it myself.

[meg23]

From schal...@darkmist.net on February 26, 2010 17:15:28

I'm closing this as I know of no platforms where tests are failing currently. Feel
free to reopen it if I am incorrect.

Status: Fixed