Add support for Kong 0.10 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Kong 0.10. This included changes to api validation to support backwards incompatible field changes. Also added a package config `kongVersion`. This is currently defaulted to `0.9` but can be set by`npm config kingkong:kongVersion 0.10` to test against other Kong versions. Tests are configured to use `kongVersion` as part of the spec file name.
esatterwhite
requested changes
Apr 5, 2017
lib/validation/api.js
Outdated
| @@ -14,9 +14,12 @@ var joi = require('joi') | |||
| module.exports = joi.object({ | |||
| name: joi.string() | |||
| , request_path: joi.string().optional() | |||
| , uris: joi.array().items(joi.string().optional()) | |||
There was a problem hiding this comment.
If 0.9 and 0.10 don't have a compatible API, I don't think this project should try to maintain compatibility with breaking changes in the project.
Someone could Have 0.10 Kong instance running and make a valid 0.9 request.
I'd much rather follow suite: just make the changes required to work with 0.10, disregard 0.9. I'll just publish a new major version.
I can set up CI to run on a tag for each Kong version. Less cruft in the code, less prone to user error and easier to deal with.
Mind just removing the old 0.9 stuff?
Thanks!
|
@esatterwhite Good call. I removed the 0.9 compatibility. |
esatterwhite
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Kong 0.10. This included changes to api
validation to support backwards incompatible field changes. Also
added a package config
kongVersion. This is currently defaultedto
0.9but can be set bynpm config set kingkong:kongVersion 0.10to test against other Kong versions. Tests are configured to use
kongVersionas part of the spec file name.