Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerContext is ignored #13

Closed
cpt-pete opened this issue May 13, 2021 · 1 comment · Fixed by #15
Closed

dockerContext is ignored #13

cpt-pete opened this issue May 13, 2021 · 1 comment · Fixed by #15
Labels
bug Something isn't working released

Comments

@cpt-pete
Copy link

cpt-pete commented May 13, 2021 •
edited

I am unable to get the 'dockerContext' to be incorporated into the build command with version 3.1.

I have the following .releaserc

{
  "plugins": [
    "@semantic-release/commit-analyzer",
    "@semantic-release/release-notes-generator",
    [
      "@codedependant/semantic-release-docker",
      {
        "dockerImage": "semantic-releases-playground",
        "dockerFile": "src/SemanticReleasesPlayground/Dockerfile",
        "dockerRegistry": "eu.gcr.io",
        "dockerContext" : "src/SemanticReleasesPlayground",
        "dockerProject": "testProject"
      }
    ]
  ]
}

Which produces the following docker build command (I've removed the build args for clarity):

docker build --quiet --tag eu.gcr.io/testProject/semantic-releases-playground:66288ac184c57590dfd3 -f /src/SemanticReleasesPlayground/Dockerfile .

I'm expecting the context to be 'src/SemanticReleasesPlayground' but it's using the default of '.'
@esatterwhite esatterwhite added the bug Something isn't working label Sep 18, 2021
esatterwhite added a commit that referenced this issue Sep 18, 2021
@esatterwhite
fix(config): ensure the docker context is passed image builds
8051256 
The `dockerContext` options was documented but never implemented making
it always utilize the default value of `.` or cwd. update steps to pass
the context which the docker Image class will resolve against the
current working directory

Fixes: #13
@esatterwhite esatterwhite mentioned this issue Sep 18, 2021
Merged
esatterwhite added a commit that referenced this issue Sep 18, 2021
@esatterwhite
fix(config): ensure the docker context is passed image builds
1367e24 
The `dockerContext` options was documented but never implemented making
it always utilize the default value of `.` or cwd. update steps to pass
the context which the docker Image class will resolve against the
current working directory

Fixes: #13
esatterwhite added a commit that referenced this issue Sep 18, 2021
@esatterwhite
fix(config): ensure the docker context is passed image builds
366b8d1 
The `dockerContext` options was documented but never implemented making
it always utilize the default value of `.` or cwd. update steps to pass
the context which the docker Image class will resolve against the
current working directory

Fixes: #13
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(config): ensure the docker context is passed image builds esatterwhite/semantic-release-docker
2 participants
@esatterwhite @cpt-pete