Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated usages of React.PropTypes #71

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Replace deprecated usages of React.PropTypes #71

merged 2 commits into from
Jan 3, 2018

Conversation

leoskyrocker
Copy link

@leoskyrocker leoskyrocker commented Dec 27, 2017 •
edited
Loading

Fixes #70.

There's a previous attempt from PR #69. However, the fix is incomplete.
This PR is a superset of the previous PR:

Replaced React.PropTypes with PropTypes from the prop-types package to support React 16 and higher.

This was referenced Dec 27, 2017
Merged
Closed
@leoskyrocker
Copy link
Author

Please help review and merge @markusguenther @esbenp, thanks!

@leoskyrocker leoskyrocker mentioned this pull request Dec 27, 2017
Closed
@esbenp esbenp merged commit c4520f9 into esbenp:master Jan 3, 2018
@esbenp
Copy link
Owner

esbenp commented Jan 3, 2018

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined is not an object when importing fresh install
3 participants
@leoskyrocker @esbenp @jdcc2